[Proposal] Update `tx_claim_rewards`

Governance Ops
1

Proposing to update the tx_claim_rewards wasm on-chain.

There is a known issue with the current transaction that results in asymptotic iteration within a specific code path in the presence of many redelegations. As a result, some users with many redelegations have been unable to successfully claim their rewards from certain validators. This proposal should unblock those claimers.

The new WASM has been deployed and tested on Housefire testnet with Proposal #33.

The code used to generate the WASM for the proposal that was placed on Housefire testnet and that will be used for mainnet can be found here. The new tx_claim_rewards wasm file included in the proposal and to be written to the Namada storage was generated from namada#4666 and can be specifically found in the CI artifacts from here. This is the same claim-rewards logic that is present in the new namada release v101.1.1.

In the opinion of Heliax, it is important to update this wasm and vote this proposal through before beginning Phase 5.

9 Likes
2

Knowable supports this. Keep going! :locomotive:

1 Like
3

Proposal #23 is now on-chain!

3 Likes
4

TuDudes supports this too! Thank you :folded_hands:

1 Like
5

Hashes match :white_check_mark:!

Proposal on-chain:
94b466692129203af0d794e9f0ca83143a69587f6771413fb24345eaa5aa8989

Building update_tx_claim_rewards_2.wasm from commit 6da3b4b using earthly +build: 94b466692129203af0d794e9f0ca83143a69587f6771413fb24345eaa5aa8989

3 Likes
6

hey! i really appreciate this, @zenodeapp
it may not seem like a big deal, but it is, and could easily go overlooked

1 Like
7

Technically we also ought to verify the code inside the embedded tx_claim_rewards.wasm

1 Like
8

Verify that the source code does not drain everyone or some other funny stuff:

image
image1547×1030 80.2 KB

Download the wasm artifacts from the Checks tab > Lint :broom: Build :hammer_and_wrench: Test :vertical_traffic_light: (quickly, before the link expires):

image
image1409×780 56.6 KB

Open the zip and compare the checksum with the one in the proposal:

image

2 Likes
9

We verified that update_tx_claim_rewards_2.wasm from the CI artifact matches the on-chain hash:
94B466692129203AF0D794E9F0CA83143A69587F6771413FB24345EAA5AA8989.

We also confirmed that the hash inside the proposal file matches the CI artifact for tx_claim_rewards.wasm:
e62fbbbb5de5ddb822439795234bac61e2cdbd70b5cb5015caca17ad210b7f96.
So voted yes.

However, one thing is still unclear to us:
How can we verify that the changes in PR #4666 are the only ones affecting this WASM file (tx_claim_rewards.e62fbbbb5de5ddb822439795234bac61e2cdbd70b5cb5015caca17ad210b7f96.wasm), and that no other files or modifications are influencing this build?

2 Likes