[Proposal] Update `tx_withdraw` on-chain with events

Governance Ops Proposal 🗳️
1

I’m proposing a simple update to the tx_withdraw wasm on-chain. With this update, any withdraw tx will emit an event that contains the withdrawn NAM amount, which is very useful for a variety of integrators and community builders.

The intended effects have been tested and verified on Housefire testnet with Prop #61.

The exact same gov proposal wasm code will be executed on mainnet and can be viewed here.

The tx_withdraw wasm code that will be written on-chain within the gov proposal code was generated with the change to the namada git repo within #4778.

2 Likes
2

The proposal is now on-chain as Prop #30! Voting begins in about 20 minutes from time of writing and will extend until next Wednesday. Estimated execution is Thursday morning CET.

3

Thanks Brent. Does this primarily affect those tracking staking reward claims?

4

Bit late, but here are the hash checks:

Proposal (Wrapper)

  • Proposal on-chain:
    e3fba2a2d8c42894822020628f8d27b6857edc5a5373a2b327dbce1a2aa0dc2d

  • Building update_tx_withdraw.wasm from commit b3221f0 using earthly +build:

    • sha256sum update_tx_withdraw.wasm

      • e3fba2a2d8c42894822020628f8d27b6857edc5a5373a2b327dbce1a2aa0dc2d update_tx_withdraw.wasm

Result: hashes match :white_check_mark:

Old tx_withdraw code

  • Old transaction hash in proposal code:
    8a9df03a1a8f5e9e606e14a97fdfb2097dba062da1b3b2158bbfa7deabeeadfb

  • Old transaction hash from a db dump (namadan ledger dump-db) at height 3381792:

    • cat db_dump_3381792.toml | grep "tx_withdraw“

      • "#tnam1qsqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqxdl54l/wasm/hash/tx_withdraw.wasm" = "8a9df03a1a8f5e9e606e14a97fdfb2097dba062da1b3b2158bbfa7deabeeadfb"

      • "#tnam1qsqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqxdl54l/wasm/name/tx_withdraw.wasm" = "8a9df03a1a8f5e9e606e14a97fdfb2097dba062da1b3b2158bbfa7deabeeadfb"

Result: hashes match :white_check_mark:

New tx_withdraw code

  • New transaction hash in proposal code:
    a8686ae87aa940e3c45adb79cb5e1daa71033d41fe85f6b32713ae3cef21ff25

  • I believe the logs and artifacts for the action (this?) that generated this new transaction hash expired? Not sure if I’m able to check this out anymore.

Result: unknown :white_question_mark:

1 Like